zeeke / sriov-cni / 12802984914

40%

master: 46%

Build Type

push

github

Committed by zeeke

Commit Message

Lock PCI allocated file

When running on heavy a load, sriov-cni might be invoked multiple times
by the kubelet or the container runtime. In these situations, it might happen
that a `cmdAdd` or a `cmdDel` run on the same device that is still handled by
a `cmdDel` instance (e.g. when the IPAM plugin takes a long time to finish).

This commit adds a Lock mechanism around the `/var/lib/cni/sriov/<PCI>` address,
to avoid two or more instances handling the same the device.
The lock is based on `flock` [1] using the `O_CLOEXEC` flag, which  garantees that the lock
is released when the process finishes.

[1] https://linux.die.net/man/2/flock

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

Run Details

7 of 45 new or added lines in 3 files covered. (15.56%)

39 existing lines in 3 files now uncovered.

550 of 1370 relevant lines covered (40.15%)

2.11 hits per line