rust-bitcoin / rust-bitcoin / 12800818823

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3907: units: Fix `ref_option` clippy lint

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/29f1a4613a090cd23baded1ef577aa4e3da8d33f">29f1a4613 Enable `ref_option` lint and allow individually (Jamil Lambert, PhD)

Pull request description:

  The last `TODO` in #3825

  Allow the `ref_option` lint in the cases where the lint wants us to change the API to ```use `Option<&T>` instead of `&Option<T>` ```

  The other option would be to keep the lint as `allow` and add a comment to `Cargo.toml` as to why we are allowing it like the other cases that are allowed.

  Close #3825

ACKs for top commit:
  apoelstra:
    ACK 29f1a4613a090cd23baded1ef577aa4e3da8d33f; successfully ran local tests; nice!
  tcharding:
    ACK 29f1a4613a090cd23baded1ef577aa4e3da8d33f

Tree-SHA512: 181d61706841085c88db058034305c63aa2

20838 of 25094 relevant lines covered (83.04%)

17445.9 hits per line