rust-bitcoin / rust-bitcoin / 12795489248
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 117
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.043% (-0.03%) from 83.07%
12795489248

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#3905: units: Remove `InputString` from the public API

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/56286265a55368572c61b03bcb81fe04fb7921c0">56286265a<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/87d93891a32d72150343195a1a20088bb6ae30cd"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/39523ea1f528231c33faa5ba1aa8900ee30349dc">39523ea1f</a> units: Remove InputString from the public API (Tobin C. Harding)

Pull request description:

  Currently `InputString` is in the public API of `units` because of the trait bound on `parse::int()`. We can just do the monomorphisisation manually to remove it.

  This patch renames `int` to have three different names, one for `&str` one for `String`, and one for `Box<str>` e.g., `units::parse::int_from_str`.

  Close #3708

ACKs for top commit:
  apoelstra:
    ACK 56286265a55368572c61b03bcb81fe04fb7921c0; successfully ran local tests; this looks great!

Tree-SHA512: 5c16640fe79ca64b2271bfdd710ce4aa735

12 of 24 new or added lines in 4 files covered. (50.0%)

1 existing line in 1 file now uncovered.

20838 of 25093 relevant lines covered (83.04%)

17415.86 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
30.56
 0.0% bitcoin/src/blockdata/script/witness_version.rs
11
73.68
 -2.85% units/src/parse.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
73.68
 -2.85% units/src/parse.rs
Jobs
ID Job ID Ran Files Coverage
1 12795489248.1 117
83.04
 GitHub Action Run
Source Files on build 12795489248