Yoast / PHPUnit-Polyfills / 12782524653

98%

3.x: 98%

push

github

Modernizer: add scalar + return type declarations (wherever possible)

In line with the new minimum of PHPUnit 7.x, the assertions in the PHPUnit Polyfills will now have both parameter as well as return type declarations (wherever possible considering the minimum supported PHP version of PHP 7.1).

Additional type declarations will be added in future majors if/when the minimum supported PHP version allows for it.

Includes removing polyfilled inline type checks for assertions which were introduced in PHPUnit with declared types, but for which the polyfills couldn't type the parameters prior to this.

Includes minor adjustments to exception expectations in the tests to allow for the PHP native `TypeError`s - in contrast to the emulated ones.

Notes:
* `AssertObjectProperty`: the `string` type for the `$propertyName` parameter for the `assertObject[Not]HasProperty()` has not been applied as it would invalidate the type check (as we can't enforce `strict_types` for tests using the assertion).

Refs:
* https://github.com/sebastianbergmann/phpunit/commit/852e5405d
* https://github.com/sebastianbergmann/phpunit/commit/a7ab2b9b5

74 of 74 new or added lines in 16 files covered. (100.0%)

589 of 599 relevant lines covered (98.33%)

141.28 hits per line