babelfish-for-postgresql / babelfish_extensions / 12782058233

77%

Build Type

push

github

Committed by web-flow

Commit Message

Implement modulo operator for MONEY/SMALLMONEY types (#3401)

Description
-----------
Due to the missing modulo operator for MONEY/SMALLMONEY types, it will choose
the other Postgres internal alternatives like int4mod and numeric_mod, which will
involve additional implicit CASTing between MONEY/SMALLMONEY types and other types.
These CASTings could cause loss of precision and wrong results. What's more, the result
of calculation won't be MONEY/SMALLMONEY types any more.

Fix
---
Implement the modulo function and operator for MONEY/SMALLMONEY types. The reason why we don't
need to implement the functions between MONEY/SMALLMONEY types and interger types is that it
will choose the MONEY-MONEY/SMALLMONEY-SMALLMONEY functions to calculate. And the result type is
expected.

Task: BABEL-5480
Signed-off-by: Bo Li <zboli@amazon.com>

Run Details

8 of 9 new or added lines in 1 file covered. (88.89%)

2 existing lines in 1 file now uncovered.

46988 of 62682 relevant lines covered (74.96%)

167051.93 hits per line