12766698809
78%
master: 80%

Ran 14 Jan 2025 11:30AM UTC

Jobs 1

Files 37

Run time 1min

Badge

Embed ▾

Committed 14 Jan 2025 11:29AM UTC coverage: 78.273%. Remained the same

Build # 12766698809

Build Type

push

github

Committed by

web-flow

Commit Message

CP-51692: Do not enable Event.next ratelimiting if Event.next is still used internally (#6222)

This fixes a performance regression on `feature/perf` with all feature
flags disabled.

By default Event.next is still used internally, so although this API is
deprecated do not yet enable the throttling by default. Fixes:
3e1d8a27a7 ("CP-51692: Event.next: use same batching as Event.from")
Fixes: 2b4e0db649 ("CP-49158: [prep] Event.{from,next}: make delays
configurable and prepare for task specific delays")

It slows down all synchronous API calls that create tasks, like
VM.start.

Only enable the throttling when Event.next is not used internally
(`use-event-next = false` in xapi.conf), which will eventually become
the default.

The code prior to the above changes used 0 delay between checking for
events, so do the same here (although this lead to a lot of inefficient
wakeups of all active tasks in XAPI, whenever anything changes, it
matches previous behaviour)

(the code for Event.from used a 50ms delay, which matches the default
for that setting already)

Run Details

3462 of 4423 relevant lines covered (78.27%)

0.78 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	python3.11 - 12766698809.1	14 Jan 2025 11:30AM UTC	37	78.27	GitHub Action Run

xapi-project / xen-api / 12766698809
78%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12766698809

xapi-project / xen-api / 12766698809 78% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12766698809

xapi-project / xen-api / 12766698809
78%
master: 80%

README BADGES
x