• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Return-To-The-Roots / s25client / 12744223927
51%

Build:
DEFAULT BRANCH: master
Ran 13 Jan 2025 09:47AM UTC
Jobs 1
Files 785
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

13 Jan 2025 09:26AM UTC coverage: 50.258% (+0.03%) from 50.224%
12744223927

push

github

Flamefire
Fix improved alliances for close start positions

With the addon enabled the territory for the HQ won't be calculated
correctly when they are too close.
The code runs into this condtion that reset the owner for territory
gained by a newly placed HQ:
`ownerOfTriggerBld == oldOwner && oldOwner > 0 && reason == TerritoryChangeReason::Build`
When the HQs are too close the position of the newly placed HQ already
belongs to a player and as ownership wasn't yet set for the position of
the HQ `ownerOfTriggerBld` wrongly refers to that player.

Fix by explicitely handling the case of "building" an HQ by setting
`ownerOfTriggerBld` to the new owner of the point, which is the owner of the HQ.

Fixes #1733

9 of 10 new or added lines in 1 file covered. (90.0%)

4 existing lines in 1 file now uncovered.

22325 of 44421 relevant lines covered (50.26%)

36882.97 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
84.15
2.15% libs/s25main/world/GameWorld.cpp

Uncovered Existing Lines

Lines Coverage ∆ File
4
61.9
-3.81% libs/s25main/nodeObjs/noMovable.cpp
Jobs
ID Job ID Ran Files Coverage
1 12744223927.1 13 Jan 2025 09:47AM UTC 785
50.26
GitHub Action Run
Source Files on build 12744223927
  • Tree
  • List 785
  • Changed 242
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • d2be19df on github
  • Prev Build on master (#12526483094)
  • Next Build on master (#12843029264)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc