babelfish-for-postgresql / babelfish_extensions / 12741819145

77%

Build Type

push

github

Committed by web-flow

Commit Message

Fixed CASE statement to work correctly when branch expression is of Numeric and Decimal type (#3389)

* Fixed CASE statement to work correctly when branch expression is of Numeric and Decimal type (#3236)

Issue:
- The CASE statement was unable to calculate the correct common typmod when the common type of the CASE statement was NUMERIC or DECIMAL. For CASE expressions, we relied on a PostgreSQL function to calculate the typmod when the common type was NUMERIC or DECIMAL. However, this approach showed different behavior from T-SQL. Therefore, we need to calculate the common typmod according to T-SQL documentation to ensure consistency with T-SQL behavior.

Changes made to fix the issues:
- The tsql_select_common_typmod_hook() function has been modified to return a common typmod for all branches when the branch expression is of NUMERIC or DECIMAL data types. This calculation now follows the T-SQL documentation. Additionally, we've added a 'case T_CoerceToDomain' in the 'resolve_numeric_typmod_from_exp' function to address issues related to user-defined types (UDTs).
- We have enhanced the 'resolve_numeric_typmod_from_exp' function by adding support for 'T_SubLink' and 'T_CoerceToDomain' nodes. This improvement enables accurate typmod calculation for expressions involving subqueries (T_SubLink) and user-defined types (T_CoerceToDomain).

Issues Resolved
Task: BABEL-5341

cherry-picked from: #3236

Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Co-authored-by: yashneet vinayak <yashneet@amazon.com>

Run Details

126 of 131 new or added lines in 3 files covered. (96.18%)

27 existing lines in 2 files now uncovered.

46940 of 62631 relevant lines covered (74.95%)

167201.44 hits per line