rust-bitcoin / rust-bitcoin / 12701200732

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3885: io: Allow setting position bigger than inner buffer

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/e315aaf1c65225b89435d0a60907a3233caa5db1">e315aaf1c io: Allow setting position bigger than inner buffer (Tobin C. Harding)

Pull request description:

  Currently if one calls `set_position` on a cursor setting the position greater than the total length of the inner buffer future calls to `Read` will panic. Bad `Cursor` - no biscuit.

  Mirror the stdlib `Cursor` and allow setting the position to any value. Make reads past the end of the buffer return `Ok(0)`.

ACKs for top commit:
  apoelstra:
    ACK e315aaf1c65225b89435d0a60907a3233caa5db1; successfully ran local tests

Tree-SHA512: 71b151218a6517b4666a6b1fae151d06ea0

23 of 23 new or added lines in 1 file covered. (100.0%)

20779 of 25025 relevant lines covered (83.03%)

17504.53 hits per line