safe-global / safe-smart-account / 12694954649

94%

push

github

[Certora Audit] I-03. Inconsistency in formula for `performCreate` and `performCreate2` (#887)

Commutativity makes the two additions equivalent but Certora recommend
the fix below for
readability and to follow the standard given that:
- `deploymentData` gives a pointer to the start of the array (length
position).
- Adding `0x20` skips the first 32 bytes (length field) to point
directly to the start of the payload.

Change:
*
[`contracts/libraries/CreateCall.sol`](diffhunk://#diff-d5d801f2308c18c5f691f73dfd552e36eL25-R25):
Changed the order of parameters in the `create2` function call to
correctly add the offset to `deploymentData`.

Co-authored-by: Mikhail <16622558+mmv08@users.noreply.github.com>

325 of 366 branches covered (88.8%)

Branch coverage included in aggregate %.

499 of 511 relevant lines covered (97.65%)

100.88 hits per line