tarantool / luajit / 12686220425

93%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

Fix compilation of getmetatable() for UDTYPE_IO_FILE

The patch fixes a problem with recording `getmetatable()`
for an I/O object: recording the `getmetatable` call with file
descriptors represented by userdata object `UDTYPE_IO_FILE`
(like `io.stdout`) leads to violation of assertion in
`rec_check_slots`.

Note, the problem was fixed upstream in different manner, see
commit 5141cbc20
("Fix compiliation of getmetatable() for UDTYPE_IO_FILE.").
Note, the specialization omits the check of `__metatable` field
precense and the check for the metatable itself. So, if we change
the metatable on the object after the trace is compiled, the trace
becomes invalid. The proposed test demonstrates these cases as
well.

Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit 0b4fe7b28)

Run Details

5688 of 6033 branches covered (94.28%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

30 existing lines in 6 files now uncovered.

21693 of 23449 relevant lines covered (92.51%)

2973853.34 hits per line