rust-bitcoin / rust-bitcoin / 12678476993

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3880: Derive `Clone`on consensus errors

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/2f91092d773e1618314b62c9e3eae17c08e1f5ad">2f91092d7 Derive Clone on consensus errors (Tobin C. Harding)

Pull request description:

  All error types in the repo use either [0]:

  - `#[derive(Debug, Clone, PartialEq, Eq)]``
  - `#[derive(Debug)]`

  However the `consensus` error types do not have `Clone` derived.

  Derive `Clone` on `consensus::ParseError` and `consensus::Error`.

  [0] Excluding `PushBytesError`, fixed in #3879

ACKs for top commit:
  apoelstra:
    ACK 2f91092d773e1618314b62c9e3eae17c08e1f5ad; successfully ran local tests; lgtm

Tree-SHA512: 2cae6faae44ca073bc1ff2779845c2cb2c1

20721 of 24967 relevant lines covered (82.99%)

17413.88 hits per line