kubevirt / hyperconverged-cluster-operator / 12669543449

76%

Build Type

push

github

Committed by web-flow

Commit Message

Cleanup upgrade code (#3260)

* Remove unused code

Drop all the code that deals with the removal of v2v CRDs and resources
during upgrade. After a few versions this code is running on upgrade, we
can be sure there is no installation of v2v we need to handle anymore.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Remove unused code, that drop CRD version on upgrade

The v1aplpha1 API version of HCO was removed many versions back, and we
can be sure that by now, it's not exist anymore. The code that removes
this version from the CRD on upgrade is not needed.

This commit droped the code that removes the v1alpha1 API version for
the CRD on upgrade.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Code cleanup: drop redundant conditions

Drop two cases of conditions that are knowns and shouldn't be a
condtions.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Move the upgradePatches code to its own package

This will ease the maintenace of the upgrade related code and will
cleanup the hyperconverged controller code.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Introduce the crwriter tool

The crwriter tool generates the HyperConverged CR with its default
values, in one of three formats: yaml (default), json, or go file that
contains a json string.

The tool was added in order to auto generate a file that HCO will use to
validate the upgradePatches.json file on boot, even if the
HyperConverged CR is not deployed yet.

It can be used in other places, like replacing the code in the
manifest-templator tool that generates the deploy/hco.cr.yaml, to be
more explicit, or to deploy the HyperConverged CR on hack/deploy.sh.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Move the upgradePatches file validation to boot

HCO validates the upgradePatches.json file only after the HyperConverged
CR is created, and if it's not valid, HCO exit with error. This is too
late to kill the HCO pod. Th... (continued)

Run Details

121 of 157 new or added lines in 2 files covered. (77.07%)

2 existing lines in 1 file now uncovered.

6016 of 8413 relevant lines covered (71.51%)

0.79 hits per line