12669431614
90%
main: 85%

Ran 08 Jan 2025 11:14AM UTC

Jobs 1

Files 32

Run time 1min

Badge

Embed ▾

Committed 08 Jan 2025 11:10AM UTC coverage: 90.467% (-0.1%) from 90.573%

Build # 12669431614

Build Type

push

github

Committed by

web-flow

Commit Message

Refactor service event to distinguish event with data or without (#308)

Only charging events have data and some of them have the data optionally.
It could make sense to get only two types of events: with data or without.
Currenly only charging events will have these types, all other service
events will be of ServiceEvent base type.

This solution has pros and cons:
- this is simpler and shorter
- only two event types to distinguish and process
But:
- this solution is not future proof: if any of the event start to get
other data, it would be required to introduce new types anyway which
will make mqtt._parse_topic function to look even more ugly and
complicated than now.

NOTE!!! This change is not compatible with current one that is used in
HA addon. Adaptation is required.

Co-authored-by: WebSpider <WebSpider@users.noreply.github.com>

Run Details

1936 of 2140 relevant lines covered (90.47%)

0.9 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
9	82.66	0.73%	mqtt.py
15	75.29	-6.6%	models/service_event.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	12669431614.1	08 Jan 2025 11:14AM UTC	32	90.47	GitHub Action Run

skodaconnect / myskoda / 12669431614
90%
main: 85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 12669431614

skodaconnect / myskoda / 12669431614 90% main: 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 12669431614

skodaconnect / myskoda / 12669431614
90%
main: 85%

README BADGES
x