babelfish-for-postgresql / babelfish_extensions / 12667158541
77%

DEFAULT BRANCH: BABEL_5_X_DEV
Ran
Jobs 1
Files 115
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 74.898% (+0.003%) from 74.895%
12667158541

push

github

web-flow 
Fix issue with convert function when converting string to date, datetimeoffset, datetime2, datetime, smalldatetime or time (#3336)

This PR will add fix for following issues:

    For converting string to datetime2, datetimeoffset and smalldatetime using convert function, we are directly using cast function which will convert the string to given type with default style. Added support to use corresponding SQL helper functions defined which will fix this issue.
    For conversion of string to date, datetime, smalldatetime and time using convert function, there are helper functions defined but are unable to handle all the supported datetime string literals. Refactored these definitions and fixed this issue.
    For conversion of string to datetime2 and datetimeoffset using convert function, there are no helper functions defined which handles this conversion as there are for conversion of string to date, datetime, smalldatetime and time. Added definitions to handle these datatypes as well.
    Function sys.babelfish_get_microsecs_from_fractsecs() is unable to handle the edge case where fractional seconds get overflowed after rounding it to given scale.
    Function babelfish_get_timeunit_from_string only returns HOURS, MINUTES, SECONDS and FRACTSECONDS from a given time string. Extended this function to return OFFHOURS, OFFMINUTES and OFFSIGN to get details of timeoffset from time string.

Cherry-picked from: #2622, #2653

Task: BABEL-4896

Signed-off-by: Rohit Bhagat rohitbgt@amazon.com

46670 of 62311 relevant lines covered (74.9%)

167234.38 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
81.13
 -0.13% contrib/babelfishpg_tsql/src/collation.c
1
83.16
 -0.05% contrib/babelfishpg_tsql/runtime/functions.c
1
92.39
 -0.25% contrib/babelfishpg_tds/src/backend/tds/tds.c
2
76.03
 -0.63% contrib/babelfishpg_tds/src/backend/tds/tdscomm.c
Jobs
ID Job ID Ran Files Coverage
1 12667158541.1 115
74.9
 GitHub Action Run
Source Files on build 12667158541