tjcsl / tin / 12667586419

59%

push

github

Hotfix: Fix invalid query when killing submissions

This fixes the below production error:
```
  File ".../tin/tin/apps/submissions/views.py", line 106, in kill_view
    submission = get_object_or_404(submissions_editable, id=submission_id)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../site-packages/django/shortcuts.py", line 85, in get_object_or_404
    return queryset.get(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../site-packages/django/db/models/query.py", line 640, in get
    raise self.model.MultipleObjectsReturned(
tin.apps.submissions.models.Submission.MultipleObjectsReturned: get() returned more than one Submission -- it returned 5!
```

One solution would have been to append a `.distinct()` to the query, but instead it was replaced by `filter_visible()` for consistency.

398 of 885 branches covered (44.97%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1494 of 2569 relevant lines covered (58.15%)

0.58 hits per line