babelfish-for-postgresql / babelfish_extensions / 12652848008

75%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Some fixes for db_owner role (#3355)

This commit addresses the following issues in the implementation of
supporting adding of multiple users to db_owner role:
 - Name clash around internal db_owner role: We will now check if the
   internal role we are about to create already exists or not, if it
   does, we throw an error. Conversely, if a server/database principal
   exists with the same name as the internal role we are about to
   create, we will throw an appropriate error.
 - Extra rows for sp_helpuser: Added a check for RoleName column to
   only contain T-SQL roles.
 - Unable to make db_owner role schema owner: We will not change owner
   of schema if it's authorization lies with db_owner role.
 - Adding/dropping of valid users to db_owner role again should not
   throw error: During addition, if user is already member of db_owner,
   we will omit creating internal role. During drop, if user is not
   member of db_owner role, we will omit dropping the internal role.

Task: BABEL-4899, BABEL-5491, BABEL-5502

Signed-off-by: Sharu Goel <goelshar@amazon.com>

Run Details

27 of 27 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

46381 of 62242 relevant lines covered (74.52%)

165111.52 hits per line