babelfish-for-postgresql / babelfish_extensions / 12634922941

77%

push

github

Performance Improvement of create login in BBF (#3291)

Engine PR : babelfish-for-postgresql/postgresql_modified_for_babelfish#507

In Major version 16 Babelfish introduced a new role bbf_admin_role which is a member of all the roles which created implicitly from TSQL. This increases the Load on any Grant/Revoke operations that happen since in BBF to "select the role through which it gets permission to current user to grant", is inefficient and loops over members of members to find the all members of the role even though the required role is find.
This commit optimizes the selection of role with is_admin_option true for babelfish by escaping the search for any TSQL roles conditionally.

Signed-off-by: ANJU BHARTI <abanju@dev-dsk-abanju-1c-ea0b53a0.eu-west-1.amazon.com>

Issues Resolved
BABEL-5349

13 of 16 new or added lines in 2 files covered. (81.25%)

46615 of 62260 relevant lines covered (74.87%)

165284.29 hits per line