12630661729
77%

Ran 06 Jan 2025 10:48AM UTC

Jobs 1

Files 115

Run time 1min

Badge

Embed ▾

Committed 06 Jan 2025 10:16AM UTC coverage: 74.862% (-0.003%) from 74.865%

Build # 12630661729

Build Type

push

github

Committed by

web-flow

Commit Message

Fix inconsistent formatting issue in convert function when converting from money to varchar (#3337)

Description
Currently when converting from money to varchar using convert function with different style values, the result is inconsistent with the formatting. This PR will address this issue by updating the logic to handle these edge cases. The issues that will get addressed in this PR are as follows

Extra space is getting added in the beginning of the result when style parameter is 0 or 2.
When input is 0, then 0 is missing before decimal in the result for style 0 and 2. Also for style 1 the result has $ before decimal instead of 0. For example, when converting value 0 with money datatype to varchar datatype
For style 0, result is  .00
For style 1, result is $.00
For style 2, result is  .0000
When style is 2, and the input has more than 2 digits after decimal, then the result is getting rounded upto 2 digits after decimal, which ideally should be rounded upto 4 digits.

Issues Resolved
BABEL-5462 

Authored-by: Rohit Bhagat rohitbgt@amazon.com
Signed-off-by: Rohit Bhagat rohitbgt@amazon.com

Run Details

46598 of 62245 relevant lines covered (74.86%)

166182.22 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	83.16	-0.05%	contrib/babelfishpg_tsql/runtime/functions.c
1	92.41	-0.25%	contrib/babelfishpg_tds/src/backend/tds/tds.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	12630661729.1	06 Jan 2025 10:48AM UTC	115	74.86	GitHub Action Run

babelfish-for-postgresql / babelfish_extensions / 12630661729
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 12630661729

babelfish-for-postgresql / babelfish_extensions / 12630661729 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 12630661729

babelfish-for-postgresql / babelfish_extensions / 12630661729
77%

README BADGES
x