sqitchers / sqitch / 12612722094

100%

push

github

Switch from DBD::mysql to DBD::MariaDB

DBD::mysql 5 recently dropped support for building from MySQL client
libraries prior to v8. This creates challenges for people still using
earlier versions, as well as those using MariaDB.

DBD::MariaDB forked from DBD::mysql back in 2018, and maintains
compatibility with both MySQL and MariaDB. It remains compatible with
earlier versions of MySQL as well as the MariaDB client libraries. It
also includes bug fixes and more transparent support for Unicode
encoding.

So switch from DBD::mysql to DBD::MariaDB. It's largely a drop-in
replacement, with just a few additional changes:

*   Add `_dsn()` to DBIEngine and always use it to connect to the
    database. Override it in mysql.pm to replace `dbi:mysql` with
    `dbi:MariaDB`. Also override it in some other drivers that mangle
    the value returned by URI::db.
*   Remove incompatible config parameters `mysql_enable_utf8` (no longer
    needed due to the aforementioned Unicode bug fixes),
    `mysql_auto_reconnect`, and `mysql_use_result`.
*   Read DBI handle attributes starting with `mariadb_` instead of
    `mysql_`.
*   Add a `USE` statement to set the registry as the current database
    after it has been created. Not sure how this wasn't required when
    using DBD::mysql, but aligns more closely with the requirements of
    other engines.

Resolves #825.

15 of 15 new or added lines in 5 files covered. (100.0%)

4574 of 4577 relevant lines covered (99.93%)

69.05 hits per line