rust-bitcoin / rust-bitcoin / 12600768962

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3666: Implement serde modules for `FeeRate`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/f5eb8f4747a7cd303cad2b7f8f442bb31862c52a">f5eb8f474<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6501b0d7817eb137679bf742b28f0e98c8aadc7a"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/472b1d3ff34d3aae95736b378330df1b0f54acbf">472b1d3ff</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6501b0d7817eb137679bf742b28f0e98c8aadc7a"> units: Add serde regression test (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/dedae8acf2b1ee644005048f295e945242f464ae">dedae8acf</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6501b0d7817eb137679bf742b28f0e98c8aadc7a"> Implement custom serde modules for FeeRate (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d94e5f03e63d7a32d6319129ca65bf8d86781c4a">d94e5f03e</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6501b0d7817eb137679bf742b28f0e98c8aadc7a"> Move fee_rate.rs to module (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c3c1f6f82d15755600478100324a2a1b01251f83">c3c1f6f82</a> Add missing license comment to test file (Tobin C. Harding)

Pull request description:

  Implement and enforce explicit unit when serializing. This is as we do for `Amount` (see #3672 for similar).

  To test it, and as part of the 1.0 effort; add regression tests for `serde` stuff in `units`.

  With this applied one must use attributes to serialize `FeeRate`.

  ```rust
      #[derive(Serialize, Deserialize)]
      pub struct Foo {
          #[serde(with = "bitcoin_units::fee_rate::serde::as_sat_per_kwu")]
          pub fee_rate: FeeRate,
      }
  ```

ACKs for top commit:
  apoelstra:
    ACK f5eb8f4747a7cd303cad2b7f8f442bb31862c52a; successfully ran local tests; great idea!

Tree-SHA512: 0968ead56e84215cbb22a6883c0a73af764

21 of 100 new or added lines in 1 file covered. (21.0%)

20442 of 24758 relevant lines covered (82.57%)

17551.74 hits per line