skeema / go-mysql-driver / 12592740116
83%
master: 82%

LAST BUILD BRANCH: tls-mysql5-docs
DEFAULT BRANCH: master
Ran
Jobs 32
Files 19
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.141%. First build
12592740116

push

github

evanelias 
Improve TLS documentation for older servers

Older/EOL database server versions tend to be built with ancient OpenSSL or
yaSSL, which lack support for modern cipher suites and/or lack TLS 1.2+. At
the same time, recent Golang versions have updated the default client
tls.Config in ways that are incompatible with these old server versions. This
commit improves TLS documentation to mention this incompatibility, provide
sample code for solving it, and explain how "preferred" plaintext fallback
mode is not triggered in cases of TLS incompatibilities.

Closes #1635 by providing example code for solving the handshake failure.

Additional information which may be helpful for reviewers/maintainers:

TLS version
* Go 1.18+ changes the default client TLS MinVersion to be TLS 1.2
* MySQL 5.5 and 5.6 supports TLS 1.0
* MySQL 5.7.0-5.7.27 supports TLS 1.1
* MySQL 5.7.28+ supports TLS 1.2
* MariaDB 10.1+ supports TLS 1.2
* I did not examine MySQL 5.1 or MariaDB 10.0 or anything more ancient

Cipher suites
* Go 1.22+ changes the default client TLS config to remove cipher suites which
  use RSA key exchange
* MySQL 8.0+ and MariaDB 10.2+ fully support ECDHE cipher suites and are
  compatible with Go's current default cipher suite list.
* MySQL 5.x typically needs RSA key exchange cipher suites, due to
  https://bugs.mysql.com/bug.php?id=82935. Likewise for MariaDB 10.1.
* There are some exceptions, for example Percona Server 5.7 is built with a
  newer OpenSSL, https://docs.percona.com/percona-server/5.7/security/ssl-improvement.html
* It is also possible to custom compile MySQL 5.7 with a newer OpenSSL
  version to solve the cipher suite issue, but this is not common.

3250 of 3909 relevant lines covered (83.14%)

2462489.07 hits per line

Jobs
ID Job ID Ran Files Coverage
1 Linux-Go-1.23-DB-5.7 - 12592740116.1 18
82.9
 GitHub Action Run
2 Windows-Go-1.23-DB-mariadb-11.1 - 12592740116.2 18
82.71
 GitHub Action Run
3 Linux-Go-1.23-DB-8.0 - 12592740116.3 18
82.97
 GitHub Action Run
4 Linux-Go-1.23-DB-9.0 - 12592740116.4 18
82.97
 GitHub Action Run
5 Windows-Go-1.23-DB-mariadb-11.2 - 12592740116.5 18
82.81
 GitHub Action Run
6 Linux-Go-1.23-DB-mariadb-11.1 - 12592740116.6 18
82.87
 GitHub Action Run
7 macOS-Go-1.23-DB-5.7 - 12592740116.7 18
82.74
 GitHub Action Run
8 Linux-Go-1.23-DB-mariadb-10.6 - 12592740116.8 18
82.87
 GitHub Action Run
9 Windows-Go-1.23-DB-mariadb-10.11 - 12592740116.9 18
82.63
 GitHub Action Run
10 macOS-Go-1.23-DB-mariadb-10.5 - 12592740116.10 18
82.92
 GitHub Action Run
11 Windows-Go-1.23-DB-mariadb-10.5 - 12592740116.11 18
82.81
 GitHub Action Run
12 Windows-Go-1.23-DB-8.4 - 12592740116.12 18
82.79
 GitHub Action Run
13 Windows-Go-1.23-DB-mariadb-11.4 - 12592740116.13 18
82.71
 GitHub Action Run
14 Windows-Go-1.23-DB-9.0 - 12592740116.14 18
82.79
 GitHub Action Run
15 Linux-Go-1.22-DB-9.0 - 12592740116.15 18
82.82
 GitHub Action Run
16 Linux-Go-1.23-DB-mariadb-11.2 - 12592740116.16 18
82.95
 GitHub Action Run
17 Windows-Go-1.23-DB-mariadb-10.6 - 12592740116.17 18
82.74
 GitHub Action Run
18 Linux-Go-1.23-DB-mariadb-10.11 - 12592740116.18 18
83.03
 GitHub Action Run
19 Linux-Go-1.23-DB-mariadb-11.4 - 12592740116.19 18
82.87
 GitHub Action Run
20 macOS-Go-1.23-DB-mariadb-11.1 - 12592740116.20 18
82.77
 GitHub Action Run
21 macOS-Go-1.23-DB-9.0 - 12592740116.21 18
82.87
 GitHub Action Run
22 macOS-Go-1.23-DB-mariadb-11.2 - 12592740116.22 18
82.77
 GitHub Action Run
23 Windows-Go-1.23-DB-5.7 - 12592740116.23 18
82.58
 GitHub Action Run
24 Linux-Go-1.21-DB-9.0 - 12592740116.24 18
82.97
 GitHub Action Run
25 Linux-Go-1.23-DB-mariadb-10.5 - 12592740116.25 18
82.95
 GitHub Action Run
26 macOS-Go-1.23-DB-mariadb-10.6 - 12592740116.26 18
82.87
 GitHub Action Run
27 Linux-Go-1.23-DB-8.4 - 12592740116.27 18
82.9
 GitHub Action Run
28 macOS-Go-1.23-DB-mariadb-11.4 - 12592740116.28 18
82.92
 GitHub Action Run
29 Windows-Go-1.23-DB-8.0 - 12592740116.29 18
82.71
 GitHub Action Run
30 macOS-Go-1.23-DB-mariadb-10.11 - 12592740116.30 18
82.82
 GitHub Action Run
31 macOS-Go-1.23-DB-8.0 - 12592740116.31 18
82.77
 GitHub Action Run
32 macOS-Go-1.23-DB-8.4 - 12592740116.32 18
82.77
 GitHub Action Run
Source Files on build 12592740116
Coverage ∆ File Lines Relevant Covered Missed Hits/Line