• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

payjoin / rust-payjoin / 12586289971
83%

Build:
DEFAULT BRANCH: master
Ran 02 Jan 2025 05:30PM UTC
Jobs 1
Files 30
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

02 Jan 2025 05:28PM UTC coverage: 61.7% (-0.03%) from 61.734%
12586289971

push

github

web-flow
Separate send version modules (part 1) (#453)

Expose descriptive, accurate send errors so that we can switch on
them in implementations and mark payjoin sessions in persistent
storage accurately. We only want to spawn sessions that are capable
of making forward progress and drop those that cannot.

Patch overview:
1. housekeeping
2. Introduce specific SenderBuilder errors
3. make CreateRequestError v2 only since v1 can only make have sender
builder errors
4. separate the modules to reduce feature flags

This separation is incomplete because I'm still uncertain what to do
with send::ValidationError's feature gated variants. Do I make a
send::ValidationError and a send::v2::ValidationError separate? How do
those get handled in ResponseError? Does ResponseError get split into
two versions, or do I just leave a feature gated variant? That's left
for the next PR predicated on this design being an appropriate one.

Note this pays back some tech debt but leaves some slop in payjoin-cli.
Rather than making this PR 10 commits to review I left combining FeeRate
parsing to a later PR (#452).

This error puts us on the path to #392 and #403

311 of 417 new or added lines in 8 files covered. (74.58%)

2 existing lines in 1 file now uncovered.

2940 of 4765 relevant lines covered (61.7%)

965.97 hits per line

Jobs
ID Job ID Ran Files Coverage
1 12586289971.1 02 Jan 2025 05:30PM UTC 0
61.7
GitHub Action Run
Source Files on build 12586289971
Detailed source file information is not available for this build.
  • Back to Repo
  • Github Actions Build #12586289971
  • 592d1d21 on github
  • Prev Build on master (#12586213780)
  • Next Build on master (#12600684475)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc