rust-bitcoin / rust-bitcoin / 12536407310

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3769: Change method return type for to_unsigned()

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/e13355318e61e341e7cf3f17257e44d19029c6eb">e13355318<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/779768eff9762b1c0adcfe6aaee7c24531fafe37"> Add From impl (yancy)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/364e9ff775ca0b482576d6dbc3a3621c68b56ea9">364e9ff77</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/779768eff9762b1c0adcfe6aaee7c24531fafe37"> Change method return type (yancy)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fdf3336ed5952bd0ed961c2a4df6e5a91e2be6ba">fdf3336ed</a> Add unchecked variant (yancy)

Pull request description:

  Any SignedAmount can now be cast to Amount since the range is the same.  Specifically, the range for SignedAmount is (- 21 million, 21 million) while the range for Amount is (0, 21 million).  Therefore any value from Amount can be cast to a SignedAmount and it will work.  Note it's not the same and still requires checking when going from SignedAmount to Amount since Amount can't handle the negative range.

ACKs for top commit:
  tcharding:
    ACK e13355318e61e341e7cf3f17257e44d19029c6eb

Tree-SHA512: c016b51bd6bd3235ee00bbc10e217d4d16a

10 of 14 new or added lines in 4 files covered. (71.43%)

20414 of 24653 relevant lines covered (82.81%)

17666.53 hits per line