c-ares / c-ares / 12519454176

92%

main: 92%

Build Type

push

github

Committed by bradh352

Commit Message

Localhost resolution can fail if only one address family is in /etc/hosts (#947)

Resolution of 'localhost' is required to be resolved locally as per
RFC6761, and c-ares implements fallback cases if `/etc/hosts` does not
contain an entry for `localhost` as is common for Windows. However, if
`/etc/hosts` does have an address entry for one family (e.g. ipv4) but
not the other (e.g. ipv6), the fallback wasn't being called since an
entry was found.

We need to enhance the logic to always fallback if an address family is
missing after reading `/etc/hosts`. We will also add specific test cases
for this scenario to ensure it doesn't regress in the future.

Fixes #946
Signed-off-by: Brad House (@bradh352)

Run Details

211 of 214 new or added lines in 10 files covered. (98.6%)

1 existing line in 1 file now uncovered.

20854 of 22603 relevant lines covered (92.26%)

97156.26 hits per line