neo-project / neo / 12489240083

77%

Build Type

push

github

Committed by web-flow

Commit Message

Extensible capabilities and ArchivalNode (#3639)

* Capabilities: rephrase FullNode

FullNode is used by all proper nodes currently whether they drop old chain
data or not. It'd be more correct to define it as "having complete state"
rather than "having all blocks" since the latter is what ArchivalNode will
provide. This is also relevant wrt how this capability is used, see RemoteNode
OnRelay() and OnSend(). Refs #2346.

Signed-off-by: Roman Khimov <roman@nspcc.ru>

* Capabilities: reserve 0xf0-0xff region for private experiments

Similar to TransactionAttributeTypes (#1904), we should have some reserved
values.

Signed-off-by: Roman Khimov <roman@nspcc.ru>

* Capabilities: make them really extensible

The way capabilities are currently defined makes them very hard to extend
since old nodes will treat unknown types as invalid ones failing Version
decoding completely. To be able to ignore these types we should also have
more uniform encoding for unknown/new types.

Signed-off-by: Roman Khimov <roman@nspcc.ru>

* Capabilities: introduce ArchivalNode

This will be used to differente full history nodes from state only. Currently
it's just a definition, we can not use it safely on current networks because
nodes will refuse this Version, so actual code using the attribute will be
added in newer versions.

Signed-off-by: Roman Khimov <roman@nspcc.ru>

---------

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Co-authored-by: Shargon <shargon@gmail.com>

Run Details

5952 of 9212 branches covered (64.61%)

Branch coverage included in aggregate %.

22 of 61 new or added lines in 7 files covered. (36.07%)

1 existing line in 1 file now uncovered.

22086 of 41263 relevant lines covered (53.52%)

83983.86 hits per line