basilisp-lang / basilisp / 12468900253

99%

Build Type

push

github

Committed by web-flow

Commit Message

Switch Python import machinery to focus primarily on Python modules (#1176)

Fixes #1165 and #1155

This PR changes the Python `importlib` machinery for Basilisp to simply
focus on importing modules, without getting itself too mixed up in the
business of figuring out what a namespace is actually _called_ from the
module name. When `importlib.import_module` is called, Basilisp just
figures out the location of the module on disk and starts loading it up
as if it were a Basilisp module. It sets the newly introduced
`basilisp.core/*import-module*` dynamic Var to the value of the
importing module and lets the Basilisp runtime fetch that value down and
attach it to a new namespace if and when it is appropriate to do so.

There may be some unintended side effects here for strange cases, so
noting those here for now:
* If multiple namespaces are created within a single invocation of
`import.import_lib` (excluding recursive calls for other imports or
requires), a module could be attached to multiple namespaces. I'm not
sure if that's actually an issue, but it's certainly bizarre and could
lead to some unintended consequences. That being said, I don't really
think it is a priority for the project to support this style of bizarre
metaprogramming, so that may be fine.
* Namespace names and module names aren't necessarily "linked" anymore,
although they never were linked directly before due to the required
munging of module names for Python code.
 * Others?

Run Details

1031 of 1040 branches covered (99.13%)

Branch coverage included in aggregate %.

60 of 61 new or added lines in 5 files covered. (98.36%)

5 existing lines in 1 file now uncovered.

8837 of 8960 relevant lines covered (98.63%)

0.99 hits per line