AAEmu / AAEmu / 12452648294

2%

Build Type

push

github

Committed by web-flow

Commit Message

[Game] Fix looting rules (for NPCs) (#1118)

* [Game] Loot Packet Update

Updated loot packets and related functions to be more structured than just using the ulong as ID

* [Game] Update loot owner from uint to bc

It looks like the `uint` for the `lootOwnerObjId` is actually a `bc` and a `byte` instead.
Changed all the references to use this format.

* [Game] Added LootingContainer class

- Added ``LootingContainer`` and ``LootingContainerItemEntry`` classes as a property of ``BaseUnit`` that will now hold loot information instead of the LootManager.
- Removed ``GetLootDropItems`` and ``CreateLootDropItems`` from ``ItemManager`` and moved their functionality to the ``LootingContainer``.
- Partially implemented ``CSLootCloseBagPacket`` and changed ``CSLootOpenBagPacket`` to use the new functions.
- Changed some functions to use ``IBaseUnit`` instead of ``BaseUnit``.
- Added ``LootingRuleMethod`` enum for use in ``LootingRule``, also made the later more readable by giving more meaningful names to the properties.
- LootingRules for any drop will now be stored on the looting container so that it keeps the same rules as well when it was generated even if the party leader changes them (same as retail behavior AFAIK).
- Changed the ``ChangeLootingRule`` function to take into account the flags that the client sends.

* [Game] Fixed Rotate-Winner and LootMaster looting rules

- Added some descriptions to packet constructors related to looting.
- Added `TryDistributeLootToPlayer` function.
- Added `GetNextLootWinner` function to Team.
- Added basic loot method types implementation.
- Made it so corpses with loot take longer to despawn.
- Added consts for looting range, despawntimes with loot and minimum despawntime after looting.
- Fixed the `Rotate-Winner` looting rule to actually allow winning more than one round.
- Improved handling of `UpdateLootState`.
- Implemented `LootMaster` looting rule.
- Fixed displaying the wrong nam... (continued)

Run Details

424 of 24859 branches covered (1.71%)

Branch coverage included in aggregate %.

9 of 574 new or added lines in 27 files covered. (1.57%)

22 existing lines in 19 files now uncovered.

1919 of 83572 relevant lines covered (2.3%)

2.37 hits per line