redis / ioredis / 12431151178

89%

Build Type

push

github

Committed by web-flow

Commit Message

fix: Connection instability when using socketTimeout parameter (#1937)

The issue occurs when using socketTimeout, causing connections to become
unstable with repeated disconnections and reconnections. This happens due
to incorrect ordering of socket stream event handling.

Changes:
- Use prependListener() instead of on() for `DataHandler` stream data events
- Explicitly call resume() after attaching the `DataHandler` stream listener
- Add tests to verify socket timeout behavior

This ensures the parser receives and processes data before timeout checks,
preventing premature timeouts and connection instability.

Fixes #1919

Run Details

1148 of 1312 branches covered (87.5%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

2188 of 2330 relevant lines covered (93.91%)

4132.92 hits per line