basilisp-lang / basilisp / 12416021124

99%

push

github

Ensure `defn` metadata are always preserved as a map (#1187)

Hi,

can you please review patch to merge the `attr-map?` and the metadata in
`defn` using a `loop` rather than `conj`. It addresses #1186.

The previous `conj` operation was return in a list rather than a map.
This also appears to be the likely cause why the `:decorators` meta key
didn't work when passed in as `defn` metadata in `defasync`.

I've updated the test suite for the same.

Thanks

Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>
Co-authored-by: Chris Rink <chrisrink10@users.noreply.github.com>

1030 of 1037 branches covered (99.32%)

Branch coverage included in aggregate %.

8825 of 8944 relevant lines covered (98.67%)

0.99 hits per line