topfreegames / pitaya / 12399975055

59%

master: 69%

Build Type

push

github

Committed by web-flow

Commit Message

Fix scenarios where error messages aren't propagated correctly (#424) (#425)

* Fix scenarios where error messages aren't propagated correctly (#424)

* Improve tests for agent and service/remote to expose bad behaviors
* Breakdown test into multiple ones to make them more clear
* Fix scenarios where error messages aren't propagated correctly

---------

Co-authored-by: Felippe Durán <felippe.duran@wildlifestudios.com>

* fix(groups): add cancelFunc and Close callback

When running tests we need to ensure a graceful cleanup by
terminating/closing the context by calling the Close() method,
which should call the cancelFunc of the group service context.
This should graceful handle goroutines like groupTTLCleanup
with a sane context cancellation

---------

Co-authored-by: Felippe Durán <felippe.duran@gmail.com>
Co-authored-by: Felippe Durán <felippe.duran@wildlifestudios.com>

Run Details

17 of 36 new or added lines in 4 files covered. (47.22%)

1 existing line in 1 file now uncovered.

4923 of 8302 relevant lines covered (59.3%)

0.65 hits per line