babelfish-for-postgresql / babelfish_extensions / 12387127657

77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix error handling for already created functions that could give syntax error in newer releases (#3247)

Our code assumes that function once created will never give syntax error. But certain fixes like 5251e4a where we disallow declaring reserved @@var, functions could have been created in earlier releases which will give syntax error while executing on a version with this commit. While throwing this syntax error at time of execution of function we have not cleaned up the contexts and aborted well which leads to a crash while executing a subsequent query.
To fix this we call terminate_batch for compile errors when we get parser syntax error.

In this PR We were crashing due to this in this action and by adding this commit we are not crashing anymore.

Issues Resolved
BABEL-5455

Signed-Off-By: Kushaal Shroff <kushaal@amazon.com>

Run Details

2 of 3 new or added lines in 1 file covered. (66.67%)

2 existing lines in 1 file now uncovered.

46468 of 62111 relevant lines covered (74.81%)

162934.68 hits per line