e7h4n / rippling / 12372035693

100%

push

github

fix: atom should unmount correctly (#44)

- Issue:

```
const base$ = $value(0);
const derived1$ = $computed((get) => get(base$));
const derived2$ = $computed((get) => get(base$));

const unsub = store.sub(derived1$, ...)
store.get(derived2$)
unsub()
```

In the code above, even after executing unsub, the store still considers base$ to be in a mounted state.

- Expected behavior:

Reading `derived2$` should not affect the mount state of `base$`.

- Root cause:

AtomManager does not check if the dependent atom is in a mounted state when maintaining dependencies for base$.

- Fix:

Only Computed atoms that are themselves in a mounted state should be able to add dependencies to the atoms they read from.

380 of 380 branches covered (100.0%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

1410 of 1410 relevant lines covered (100.0%)

91.28 hits per line