babelfish-for-postgresql / babelfish_extensions / 12367805105

77%

push

github

Retain result type after UNION as base type in T-SQL (#3175)

Description
-----------
When a base type such as `money` is UNIONed with another integer type,
the result type will be `fixeddecimal` instead of `money`, which is
inconsistent with SQL Server's behaviour. And could also cause some
characters not displaying well.

Analysis
--------
The root cause of the issue is Postgres will consider the base type of
domain type as the result type. In Babelfish, `money` is implemented
as a domain type of `fixeddecimal`. Actually, `money` is a base type
in T-SQL, thus Babelfish should retain `money` type after UNION.

Fix
---
After a final type has determined by the optimizer, check if it's a
base type in T-SQL. If it is, try to use the domain type as result
type if the domain type has higher precision than other types.

Task: BABEL-5242
Signed-off-by: Bo Li <zboli@amazon.com>

3 of 3 new or added lines in 1 file covered. (100.0%)

46440 of 62066 relevant lines covered (74.82%)

163126.54 hits per line