rust-bitcoin / rust-bitcoin / 12366023693

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3728: units: Unify and flesh out ops impls

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/68f3c3e5d728a60a4b52ca64523770bcdd32f957">68f3c3e5d<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8d508e0deb6d3cc537c2da170758e2b5ef1b0997"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b956940a6dadce0bdcc3549e50b77d2ece6fc676">b956940a6</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8d508e0deb6d3cc537c2da170758e2b5ef1b0997"> Add ops unit tests for amount types (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d88306fb6887acea96c8e26e8ae9fd34371487be">d88306fb6</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8d508e0deb6d3cc537c2da170758e2b5ef1b0997"> units: Implement ops for amount types (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/4a3aa4a08b5ff12cb59db0bc6124a65431bc313e">4a3aa4a08</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8d508e0deb6d3cc537c2da170758e2b5ef1b0997"> Add ops unit tests for Weight (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/43ef9a618c6bc94d2d9e291d92e013b946e3b72d">43ef9a618</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8d508e0deb6d3cc537c2da170758e2b5ef1b0997"> units: Implement ops for Weight (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c5fbc7e117e47287c9acf5a29fef2b2402f23686">c5fbc7e11</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8d508e0deb6d3cc537c2da170758e2b5ef1b0997"> units: Add assign macros (Tobin C. Harding)
20a79da34 units: Use one level of path for ops traits (Tobin C. Harding)
6ce538591 units: Add macros for Add and Sub (Tobin C. Harding)
b31ca72b3 units: Use rhs instead of other (Tobin C. Harding)
cd0fa2d1d Make FeeRate ops impls more terse (Tobin C. Harding)

Pull request description:

  Sort out `Add`, `AddAssign`, `Sub`, and `SubAssign` for the following types:

  - `Amount`
  - `SignedAmount`
  - `FeeRate`
  - `Weight`

  And clean up as we go.

  Note that `BlockInterval` isn't touched in this PR - it looks correct already.

  The unit tests in the two patches "Add ops tests ..." can be moved if you want to verify that they don't build without the patch they follow.

ACKs for top commit:
  apoelstra:
    ACK 68f3c3e5d728a60a4b52ca64523770bcdd32f957; successfully ran local tests

Tree-SHA512: a82d3bf28bf5344132b21f82d4b9f82e729

Run Details

118 of 118 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

20418 of 24588 relevant lines covered (83.04%)

17675.03 hits per line