rust-bitcoin / rust-bitcoin / 12358025645
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 114
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.908% (-0.004%) from 82.912%
12358025645

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#3744: Change paramater type used for whole bitcoin

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/f97c04cf07c2ac5acb5d312b573d100afa009b57">f97c04cf0<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0a10d6a0ec362ea51ec0a8733cc98bc8f10f289d"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/99b32c95b834166020ce85580246dc8ff193d467">99b32c95b</a> Change paramater type used for whole bitcoin (Tobin C. Harding)

Pull request description:

  We have multiple constructors for `Amount`, one of which accepts an integer representing whole bitcoin.

  In an attempt to make the API crystal clear change the parameter type used for whole bitcoin to `u32` instead of a `u64` which may well be mapped to sats in the mind of developers (it is in mine anyway).

ACKs for top commit:
  apoelstra:
    ACK f97c04cf07c2ac5acb5d312b573d100afa009b57; successfully ran local tests

Tree-SHA512: fb22f08f1d2faeddc2fa1a7afa7e36d0674

2 of 8 new or added lines in 2 files covered. (25.0%)

1 existing line in 1 file now uncovered.

20276 of 24456 relevant lines covered (82.91%)

17798.85 hits per line

Jobs
ID Job ID Ran Files Coverage
1 12358025645.1 0
82.91
 GitHub Action Run
Source Files on build 12358025645
Detailed source file information is not available for this build.