ThreeSixtyGiving / datastore / 12354863998

91%

master: 91%

Build Type

push

github

Committed by michaelwood

Commit Message

quality_data: overview: Fix incorrect field summing passing grants

When calculating the overview stats for /api/dashboard/overview?mode=grants
the logic of fail/pass was being used to count the total number of
grants which passed by just using the total number of grants that are in
the source file.

This is only correct some of the time because it just so happens that if a
publisher is likely to be missing a field (such as company number) then they
will miss it out of all of their datasets so the calculation is coincidentally
correct. Some publishers however do add such fields for _some_ of their
grants which makes this calculation completely incorrect for certain
metrics.

This change makes sure we use the total count from the DQT (library)
rather than the aggregated data.

Updates basic test data to corrected value.

Fixes: https://github.com/ThreeSixtyGiving/datastore/issues/246

Run Details

5 of 6 new or added lines in 1 file covered. (83.33%)

2 existing lines in 1 file now uncovered.

2940 of 3244 relevant lines covered (90.63%)

0.91 hits per line