gnachman / iTerm2 / 518

30%

master: 30%

push

travis-ci

Fix a bug where unused space was left at the bottom of a fullscreen window with a horizontal split:

- Set the showTitle flag in a tab's session viws when creating a tmux tab. This fixes a bug where there would be unused space at the bottom of a fullscreen window because -recompact would throw out the extra room left for the title bar.

Fix a bug where a fullscreen window with a horizontal split with cycle between two different sizes (issue 4933):

- Make addSplitter:toIntervalMap:forHeight:origin: use the size of the scrollview, not the size of the session view. If there is a per-pane titlebar it shouldn't be counted since the height is used to compute the number of rows.

- Get rid of maxTmuxSize, which double-counted the difference between the root splitter and the flexible view that contained it (tmuxSize already took that into account).

- Make tmuxSize use the floor of the charsDiff values. That's better behaved for negative values, since tmuxSize is meant to be equal to or smaller than the size that would fit on the screen.

Finally, make replaceViewHierarchyWithParseTree: set the showTitle flag. This is mostly on general principal.

26 of 26 new or added lines in 2 files covered. (100.0%)

27588 of 92548 relevant lines covered (29.81%)

31.33 hits per line