rust-bitcoin / rust-bitcoin / 12323859033

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3738: Remove Weight::from_wu_usize function

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/3c8c95651169fb9329ceb380162721c2d2f9b3aa">3c8c95651 Remove Weight::from_wu_usize function (Tobin C. Harding)

Pull request description:

  This constructor is an anomaly in this repo. Also it is ugly to have the type parameter hard coded in the function name.

  The problem the constructor is trying to solve is that we don't like casts that don't obviously loose data. We have a solution for that already in `internals::ToU64`. This trait cannot be used in const contexts though so we do introduce a single cast in this patch.

ACKs for top commit:
  apoelstra:
    ACK 3c8c95651169fb9329ceb380162721c2d2f9b3aa; successfully ran local tests

Tree-SHA512: 168196edb9543e89fab7c5ca21db68d61ec

5 of 5 new or added lines in 2 files covered. (100.0%)

20295 of 24474 relevant lines covered (82.92%)

17711.26 hits per line