babelfish-for-postgresql / babelfish_extensions / 12298439242

77%

Build Type

push

github

Committed by web-flow

Commit Message

Allow string functions to be called with arguments of datatypes that were supported earlier (#3192)

While fixing issue in string functions for input containing multibyte characters, we blocked string functions called with some datatypes to be more compliance with TSQL, which were supported earlier by using underlying PostgreSQL string functions. This PR include changes to allow all string functions to be called on all the datatypes that were support earlier.

Following are the string functions which faced this issue and will be fixed with this PR:-

CONCAT, CONCAT_WS
STRING_AGG
TRIM, LTRIM, RTRIM, LEFT, RIGHT
REPLACE
REPLICATE
REVERSE
TRANSLATE
STUFF
SUBSTRING
LOWER and UPPER

Issues Resolved: BABEL-5337

Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>

Run Details

79 of 79 new or added lines in 3 files covered. (100.0%)

9 existing lines in 2 files now uncovered.

46437 of 62063 relevant lines covered (74.82%)

169476.3 hits per line