babelfish-for-postgresql / babelfish_extensions / 12293865521

77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix transaction leak when DMLs contains a non pltsql language function which calls another non tsql function inside try catch (#3217)

When DMLs are executed outside a user transaction block, babelfish starts an implicit transaction to handle errors inside triggers. This is done irrespective of whether the statement actually fires a trigger.
Now if the DML calls a non pltsql function which in calls another non tsql func or procedure inside a try catch, we do not properly decrement the pltsql_sys_func_entry_count variable properly. So the return value of pltsql_support_tsql_transactions() is different at beginning of the DML compared to after the end of the statement. This difference leads to babelfish not commit the implict transaction block.
As a fix, store the value of pltsql_support_tsql_transactions() at start of execution of DML and just reuse it for after execution.

Issues Resolved: [BABEL-5446]

Signed-off-by: Tanzeel Khan tzlkhan@amazon.com

Run Details

9 of 9 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

46472 of 62119 relevant lines covered (74.81%)

163407.4 hits per line