tarantool / tarantool / 12293889069

87%

master: 88%

Build Type

push

github

Committed by locker

Commit Message

vinyl: fix abort of writers on DDL

When a DDL statement is committed, all transactions writing to the space
must be aborted so that they don't access the stale `txn_stmt::space`
pointer on commit. In Vinyl we abort all writers from the special
`space_invalidate` engine callback, where we iterate over all writing
transactions and abort those of them that have a write set entry
pointing to the primary key of the invalidated space, see commit
d3e1236956515 ("vinyl: abort affected transactions when space is removed
from cache"). We also abort transactions that haven't yet created
a write set entry because they need to read the disk first, for example,
to perform a tuple update, see commit 4f62ec2102f4 ("vinyl: make
tx_manager_abort_writers_for_ddl more thorough").

However, as spotted by @drewdzzz, this code doesn't always work as
expected. The problem is, unless dropped, the primary index is moved to
the new space container so using the primary index stored in the old
space container to abort transactions is wrong: there can't possibly be
any transactions associated with it. We don't get a crash because we
have an extra check in `vy_lsm_set` that aborts the transaction if
the space format was updated (it is updated on every space change),
see commit e3c5fde4b57cd ("vinyl: fix DDL with active transactions").

Another problem with `space_invalidate` is that it doesn't abort
transactions that turned out to be no-op, such as an update of
a non-existing key because such transactions don't add any entries
to the write set. Still, they must be aborted because they have
a `txn_stmt` pointing to the old space. Letting them proceed to commit
would result in a use-after-free bug, see #10707.

Let's fix `space_invalidate` by making it iterate over all statements
of writing transactions instead of checking their Vinyl write sets.
To achieve that, we store a pointer to `struct txn` in `struct vy_tx`.
This lets us drop `vy_tx::last_stmt_space` and `vy_tx::isolation`
b... (continued)

Run Details

68648 of 121880 branches covered (56.32%)

15 of 15 new or added lines in 4 files covered. (100.0%)

48 existing lines in 21 files now uncovered.

101226 of 115973 relevant lines covered (87.28%)

2968051.73 hits per line