dart-lang / native / 12284252057

82%

Build Type

push

github

Committed by web-flow

Commit Message

[native_assets_cli] Move `targetOS` to `CodeConfig` (#1806)

Next refactoring in:

* https://github.com/dart-lang/native/issues/1738

We move `config.targetOS` to `config.codeConfig.targetOS`. Other asset types might not get access on the target OS.

This will require a manual roll into dartdev and flutter tools due to the targetOS now having to be passed in via `setupCodeConfig` instead of the base config.

The native assets builder will still emit the same JSON if code assets are supported. Since both Dart and Flutter support code assets currently, this will not break anything. Once data assets for web in Flutter are added, all existing build hooks that assume code assets are always supported will break.

Run Details

32 of 33 new or added lines in 6 files covered. (96.97%)

6 existing lines in 3 files now uncovered.

11936 of 13608 relevant lines covered (87.71%)

34.19 hits per line