Ran
|
Jobs
1
|
Files
518
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
push
github
vinyl: disable tautological DELETE optimization for deferred DELETEs If the write iterator sees that one DELETE statement follows another, which isn't discarded because it's referenced by a read view, it drops the newer DELETE, see commit a6f45d870813b ("vinyl: discard tautological DELETEs on compaction"). This is incorrect if the older DELETE is a deferred DELETE statement (marked as SKIP READ) because such statements are dumped out of order, i.e. there may be a statement with the LSN lying between the two DELETEs in an older source not included into this compaction task. If we discarded the newer DELETE, we wouldn't overwrite this statement on major compaction, leaving garbage. Fix this issue by disabling this optimization for deferred DELETEs. Closes #10895 NO_DOC=bug fix (cherry picked from commit 2945a8c9f)
69655 of 123506 branches covered (56.4%)
1 of 1 new or added line in 1 file covered. (100.0%)
92 existing lines in 24 files now uncovered.102613 of 117457 relevant lines covered (87.36%)
2687426.29 hits per line
Lines | Coverage | ∆ | File |
---|---|---|---|
1 |
65.97 |
1.27% | src/lib/core/fio.c |
1 |
87.5 |
-1.59% | src/box/xlog.h |
1 |
86.49 |
-1.35% | src/box/lua/ctl.c |
1 |
89.05 |
-0.08% | src/box/vy_log.c |
1 |
96.15 |
-0.05% | src/lib/salad/bps_tree.h |
1 |
94.74 |
-1.75% | src/box/engine.h |
1 |
96.12 |
-0.18% | src/box/relay.cc |
1 |
90.51 |
-0.63% | src/box/engine.c |
1 |
95.78 |
-0.12% | src/box/replication.cc |
1 |
90.38 |
-1.92% | src/lib/core/trigger.cc |
2 |
84.62 |
-0.28% | src/lib/core/say.c |
2 |
95.45 |
-4.55% | src/lib/json/json.h |
2 |
94.22 |
-0.39% | src/lua/fiber.c |
2 |
91.46 |
0.52% | src/box/box.cc |
2 |
84.34 |
-0.1% | src/box/xlog.c |
2 |
85.71 |
-9.52% | src/lib/core/tt_sigaction.c |
3 |
92.15 |
-0.09% | src/box/vinyl.c |
3 |
90.93 |
-0.31% | src/box/vy_scheduler.c |
3 |
94.68 |
-1.06% | src/box/vy_range.c |
4 |
95.79 |
-0.32% | src/lib/msgpuck/msgpuck.h |
4 |
94.25 |
-0.39% | src/box/xrow_update_field.c |
5 |
92.84 |
-0.28% | src/lib/core/fiber.c |
15 |
89.21 |
0.38% | src/box/vy_lsm.c |
33 |
94.55 |
-0.04% | src/box/vy_tx.c |
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 12275543970.1 | 518 |
87.36 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
---|