tarantool / tarantool / 12275507221

86%

master: 88%

Build Type

push

github

Committed by locker

Commit Message

vinyl: disable tautological DELETE optimization for deferred DELETEs

If the write iterator sees that one DELETE statement follows another,
which isn't discarded because it's referenced by a read view, it drops
the newer DELETE, see commit a6f45d870813b ("vinyl: discard tautological
DELETEs on compaction"). This is incorrect if the older DELETE is a
deferred DELETE statement (marked as SKIP READ) because such statements
are dumped out of order, i.e. there may be a statement with the LSN
lying between the two DELETEs in an older source not included into this
compaction task. If we discarded the newer DELETE, we wouldn't overwrite
this statement on major compaction, leaving garbage. Fix this issue by
disabling this optimization for deferred DELETEs.

Closes #10895

NO_DOC=bug fix

(cherry picked from commit 2945a8c9f)

Run Details

63192 of 114455 branches covered (55.21%)

1 of 1 new or added line in 1 file covered. (100.0%)

99 existing lines in 14 files now uncovered.

94027 of 109404 relevant lines covered (85.94%)

2965909.34 hits per line