dart-lang / native / 12265019459

76%

push

github

[native_assets_cli] Make package:test dev dep (#1799)

- refactor the package:native_assets_cli dep on package:test; make the dep a dev_dependency instead of a regular dependency
- rename `testBuildHook` to `validateBuildHook` and `testCodeBuildHook` to `validateCodeBuildHook
- update the changelog

When doing an investigation into the deps of the `dart` cli tool, I found that this was bringing `package:test` all all its dependencies into the transitive closure of used packages. This refactors the package to still provide testing facilities but to no longer use package:test as a regular dep.

---

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before creating a PR.
- Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`.
- Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change).
- Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing).

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
</details>

0 of 3 new or added lines in 1 file covered. (0.0%)

11844 of 13356 relevant lines covered (88.68%)

34.84 hits per line