• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

roundup-tracker / roundup / 12264721070
74%

Build:
DEFAULT BRANCH: master
Ran 10 Dec 2024 09:18PM UTC
Jobs 1
Files 117
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

10 Dec 2024 09:06PM UTC coverage: 73.606% (+0.03%) from 73.58%
12264721070

push

github

rouilj
fix(web): issue2551356. Add etag header for not-modified (304) request.

When a 304 is returned to a conditional request for a static file,
print an ETag for the response.

ETag was always sent with a 200 response.

This also adds initial support for if-none-match conditional requests
for static files.

Changes:

Refactors the if-modified-since code out to a method.

It moves a file stat call from serve_static_file to _serve_file
so that an etag can be generated by both serve_static_file and
serve_file which call _serve_file.

Tests added. This does not test the codepath where serve_file pulls
content from the database rather than from a local file on disk.

Test mocking _serve_file changed to account for 5th argument to serve_file

BREAKING CHANGE:

function signature for client.py-Client::_serve_file() now has 5 not 4
parameters (added etag param). Since this is a "hidden" method I am
not too worried about it.

34 of 35 new or added lines in 1 file covered. (97.14%)

3 existing lines in 1 file now uncovered.

18406 of 25006 relevant lines covered (73.61%)

3.58 hits per line

Jobs
ID Job ID Ran Files Coverage
1 12264721070.1 10 Dec 2024 09:18PM UTC 0
73.61
GitHub Action Run
Source Files on build 12264721070
Detailed source file information is not available for this build.
  • Back to Repo
  • Github Actions Build #12264721070
  • b80e2b20 on github
  • Prev Build on master (#12227871934)
  • Next Build on master (#12278412011)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc