TuringLang / DynamicPPL.jl / 12253492086

85%

main: 83%

push

github

Using JET.jl to determine if typed varinfo is okay (#728)

* fixed calls to `to_linked_internal_transform`

* fixed incorrect call to `acclogp_assume!!`

* added `determine_varinfo` and an implementation using JET for this

* made filtering for errors only in the tilde pipeline optional

* formatting

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fixed incorrect comment

* added test for the branch we were currently imssing

* formatting

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* renamed `determine_varinfo` to `determine_suitable_varinfo` with
fallback to current behavior + `supports_varinfo` to `is_suitable_varinfo`

* removed now-redundant init used with Requires.jl, since this is no
longer needed on Julia 1.10 and onwards + added error hint for when
JET.jl has not been loaded

* `determine_suitable_varinfo` now only performs checks using the
provided context, but uses `SamplingContext` by default (as this
should be a stricter check than just evaluation)

* formatting

* updated error hint

* added def of `untyped_varinfo` which takes just `model` and `context`

* fixed incorrect call to `untyped_varinfo` in `_determine_varinfo_jet`

* explicitly call `typed_varinfo` when we want such a thing rather than
the ambiguous `VarINfo`

* `typed_varinfo` and `untyped_varinfo` handles wrapping passed context
in sampling context now so no need to handle this explicitly elsewhere

* use `determine_suitable_varinfo` in `LogDensityFunction` when not constructed

* formatting

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* formatting

* fixed a bug in `DynamicPPLJETExt.is_tilde_instance`

* updated docs

* Update docs/src/internals/varinfo.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* added back def of `... (continued)

25 of 28 new or added lines in 4 files covered. (89.29%)

3695 of 4272 relevant lines covered (86.49%)

1144174.73 hits per line