Ran
|
Jobs
1
|
Files
514
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
push
github
vinyl: fix cache invalidation on rollback of DELETE statement Once a statement is prepared to be committed to WAL, it becomes visible (in the 'read-committed' isolation level) so it can be added to the tuple cache. That's why if the statement is rolled back due to a WAL error, we have to invalidate the cache. The problem is that the function invalidating the cache (`vy_cache_on_write`) ignores the statement if it's a DELETE judging that "there was nothing and there is nothing now". This is apparently wrong for rollback. Fix it. Closes #10879 NO_DOC=bug fix (cherry picked from commit d64e29da2)
68583 of 121826 branches covered (56.3%)
9 of 9 new or added lines in 2 files covered. (100.0%)
55 existing lines in 18 files now uncovered.101191 of 115947 relevant lines covered (87.27%)
2794534.19 hits per line
Lines | Coverage | ∆ | File |
---|---|---|---|
1 |
89.05 |
-0.08% | src/box/vy_log.c |
1 |
95.65 |
0.0% | src/box/relay.cc |
1 |
90.51 |
-0.63% | src/box/engine.c |
1 |
95.05 |
-0.31% | src/box/raft.c |
1 |
94.74 |
-1.75% | src/box/engine.h |
1 |
92.95 |
-0.07% | src/lib/core/fiber.c |
1 |
22.68 |
0.04% | src/lib/uri/uri_parser.c |
1 |
88.83 |
-0.16% | src/box/vy_lsm.c |
2 |
84.27 |
-0.16% | src/box/xlog.c |
2 |
96.12 |
0.0% | src/lib/msgpuck/msgpuck.h |
2 |
92.81 |
-1.44% | src/box/vy_point_lookup.c |
2 |
94.11 |
-0.39% | src/lua/fiber.c |
2 |
92.12 |
0.05% | src/box/vinyl.c |
4 |
81.82 |
-12.12% | src/lua/minifio.c |
4 |
93.31 |
-1.27% | src/lib/swim/swim_io.c |
4 |
90.93 |
-0.42% | src/box/vy_scheduler.c |
9 |
88.14 |
-7.63% | src/box/vy_regulator.c |
16 |
90.95 |
-0.4% | src/box/box.cc |
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 12252150082.1 | 514 |
87.27 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
---|