mochajs / mocha / 12237670440

94%

push

github

fix: error handling for unexpected numeric arguments passed to cli (#5263)

* Fix 5028 // Numerical arguments to cli throw uncaught error

This PR throws a custom error which is (hopefully) easier to understand
when:

i. a numerical argument is passed to mocha cli
ii. numerical value is used as a value for one of the mocha flags that is not compatible with
numerical values.

Signed-off-by: Dinika Saxena <dinika@greyllama.cc>

* Use type-check to throw error instead of a broad try/catch

Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>

* Rename numerical to numeric

Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>

* Find flag for mocha cli after parsing yargs

* Find flag for faulty numeric args before yargs parser

Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>

* Add js-doc private keyword to fix netlify doc deployment

* [Style] // Reduce code duplication

* Add an "it" block for each flag for easier debug-ability

Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>

* Remove ? from flag since it cannot be undefined

* Add test cases for empty string checks for isNumeric

* Do not add extra leading -- in error message for flag

* Throw error for numeric positional arg after yargs-parser has parsed args

Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>

* Revert timeout and slow as string flags so that they can accept human readable values

Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>

---------

Signed-off-by: Dinika Saxena <dinika@greyllama.cc>
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>

1409 of 1588 branches covered (88.73%)

30 of 30 new or added lines in 3 files covered. (100.0%)

3634 of 3859 relevant lines covered (94.17%)

12896.08 hits per line